-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add dependencies #221
Comments
- find required version using cargo-msrv - find the version in the readme using mdq 😎 - compare them In support of #221. This sets up a new workflow, so I need to merge it to main before it can run for final validation; but if it works, there could be no other change required for 221.
Fixed in #226 -- how does that look to you? Basically I:
|
- fix the workflow name - fix the job name - rm the `needs` dependency - put in the correct version to the readme (I had previously put an intentionally incorrect one, to prove this script works; and then I forgot to remove it) In service of (and may resolve) #221
Thanks @yshavit! I will be honest. I didn't notice the "Development" section. I guess I though it was for repo-contributors only. Thus, I would:
I feel like you want a README short and clear. You achieve it already. Good job! Thus maybe my 3rd suggestion is the clearest. |
Oh, right, I forgot the installation instructions included the |
@juanMarinero How does this look to you? https://github.com/yshavit/mdq/blob/readme-cargo/README.md#installation (note: I moved the cargo install to the last option) (PR #231) |
It looks short and clear. Thanks for coding it and asking feedback! |
- move the `cargo install` to the last option - add the requirement - change the checker to use just plain grep, and include the file name and line number, so I can use them in the workflow commands resolves #221
Hello! Please:
# Installation
section of README.md. Fromcargo install --git https://github.com/yshavit/mdq
tocargo install --git https://github.com/yshavit/mdq --tag v0.3.0
. Or keep up to date dependencies sub-section of README.md with needs of newest commit, which is much more error-prone and tedious.Thanks in advance!
For Ubuntu 24.04:
Notice: or upgrade your version of Rust.
Alike with newest mdq tag-released commit:
I update Rust (https://rust-lang.github.io/rustup/basics.html):
Install:
It seems to work:
The text was updated successfully, but these errors were encountered: