Skip to content

Commit

Permalink
move to a separate workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
yshavit committed Feb 28, 2025
1 parent 29b547d commit 425c122
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 33 deletions.
44 changes: 44 additions & 0 deletions .github/workflows/readme-checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: rust

on:
push:
branches: [ "main" ]
workflow_dispatch: {}

env:
CARGO_TERM_COLOR: always

jobs:
check msrv:
runs-on: ubuntu-latest
needs: build
steps:
- uses: actions/checkout@v4
- name: find version mentioned in readme
id: readme-version
run: |
set -euo pipefail
pwd
mkdir -p target/debug
cargo build
readme_version="$(cat README.md | ./target/debug/mdq '# Development | P: "Requires rustc >=" ' | awk '{print $NF}')"
echo "Found version in readme: <$readme_version>"
echo "result=$readme_version" >> "$GITHUB_OUTPUT"
- name: pull cargo-msrv from docker hub
run: docker pull foresterre/cargo-msrv
- name: find minimum supported rust version
id: run-msrv
run: |
set -euo pipefail
min_version="$(docker run --rm -t -v "$PWD/":/app/ foresterre/cargo-msrv find --no-log --output-format minimal | tr -d $'\r\n')"
echo "Found version in cargo-msrv: <$min_version>"
echo "result=$min_version" >> "$GITHUB_OUTPUT"
- name: compare versions
run: |
if [[ "$MSRV_VERSION" != "$README_VERSION" ]]; then
echo "::error title=msrv-mismatch::cargo-msrv was $MSRV_VERSION but README.md says rustc >= $README_VERSION"
exit 1
fi
env:
MSRV_VERSION: ${{ steps.run-msrv.outputs.result }}
README_VERSION: ${{ steps.readme-version.outputs.result }}
33 changes: 0 additions & 33 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,39 +27,6 @@ jobs:
echo "::error file=$file_path,title=git-status::<$status_code> $file_path"
done <<<"$(git status --porcelain)"
exit "$exit_code"
msrv:
runs-on: ubuntu-latest
needs: build
steps:
- uses: actions/checkout@v4
- name: find version mentioned in readme
id: readme-version
run: |
set -euo pipefail
pwd
mkdir -p target/debug
cargo build
readme_version="$(cat README.md | ./target/debug/mdq '# Development | P: "Requires rustc >=" ' | awk '{print $NF}')"
echo "Found version in readme: <$readme_version>"
echo "result=$readme_version" >> "$GITHUB_OUTPUT"
- name: pull cargo-msrv from docker hub
run: docker pull foresterre/cargo-msrv
- name: find minimum supported rust version
id: run-msrv
run: |
set -euo pipefail
min_version="$(docker run --rm -t -v "$PWD/":/app/ foresterre/cargo-msrv find --no-log --output-format minimal | tr -d $'\r\n')"
echo "Found version in cargo-msrv: <$min_version>"
echo "result=$min_version" >> "$GITHUB_OUTPUT"
- name: compare versions
run: |
if [[ "$MSRV_VERSION" != "$README_VERSION" ]]; then
echo "::error title=msrv-mismatch::cargo-msrv was $MSRV_VERSION but README.md says rustc >= $README_VERSION"
exit 1
fi
env:
MSRV_VERSION: ${{ steps.run-msrv.outputs.result }}
README_VERSION: ${{ steps.readme-version.outputs.result }}
check:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 425c122

Please sign in to comment.