Improving file panel rendering. #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for superfile canceled.
|
lazysegtree
force-pushed
the
fix_tmp_issue_585
branch
2 times, most recently
from
bc68644 to
da3c86e
Compare
lazysegtree
commented
Feb 4, 2025
| sort.Slice(files, order) | ||
|
|
||
| for _, item := range files { | ||
| fileInfo, err := item.Info() |
There was a problem hiding this comment.
No need of filtering dirEntries after. Filtered them before the sort.
lazysegtree
commented
Feb 4, 2025
| name: item.Name(), | ||
| directory: item.IsDir(), | ||
| } | ||
| if location == "/" { |
There was a problem hiding this comment.
This is redundant. filepath.Join() handles location being "/"
lazysegtree
commented
Feb 4, 2025
| switch sortOptions.options[sortOptions.selected] { | ||
| case "Name": | ||
| order = func(i, j int) bool { | ||
| _, errI := os.ReadDir(location + "/" + files[i].Name()) |
There was a problem hiding this comment.
We dont need to do ReadDir syscall here at all. We can just decide based on IsDir()
lazysegtree
force-pushed
the
fix_tmp_issue_585
branch
from
da3c86e to
c3d9fea
Compare
|
Rebased to latest main, after merge of PR#584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant computations, and improved error handling.
Fixes some issue found during investigation of #585
Renamed
foldertodirValidated that file view and sort options were working as intended.
Validated that no issues in opening root directory
\Validated that hiding and showing of dot files was working as expected