Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed configuring severity for max line length rule #420

Conversation

profhenry
Copy link
Contributor

Fix for #419.

Pull request contains 3 commits

  1. The actual fix incl. a unit test
  2. Cleanup for configurable severities which removes the need for the public SeverityInternal field
  3. Removal of the FailureWithSeverityf so that you cannot forget to set the severity

The last two are optional. Please have a look. Feel free to leave or remove them from the merge request.

Copy link
Owner

@yoheimuta yoheimuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you for the fix 👍

@yoheimuta yoheimuta merged commit 1f1793c into yoheimuta:master Jul 7, 2024
6 checks passed
@profhenry profhenry deleted the 419_configuring_severity_does_not_work_for_MaxLineLengthRule branch July 18, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants