Merge pull request #2 from yoheimuta/tests-resume

Add tests about suspend() and resume()
yoheimuta · Jul 27, 2018 · e00bfff · e00bfff
2 parents f332067 + 64a4351
commit e00bfff
Show file tree

Hide file tree

Showing 3 changed files with 96 additions and 1 deletion.
diff --git a/BufferedLogger/BufferedOutput.swift b/BufferedLogger/BufferedOutput.swift
@@ -70,7 +70,7 @@ final class BufferedOutput {
                           selector: #selector(tick(_:)),
                           userInfo: nil,
                           repeats: true)
-        DispatchQueue.main.sync {
+        DispatchQueue.main.async {
             RunLoop.main.add(timer, forMode: .commonModes)
         }
         self.timer = timer

diff --git a/BufferedLoggerTests/BufferedOutputTests.swift b/BufferedLoggerTests/BufferedOutputTests.swift
@@ -225,4 +225,91 @@ class BufferedOutputTests: XCTestCase {
                            test.name)
         }
     }
+
+    func testSuspend() {
+        let tests: [(
+            name: String,
+            callSuspend: Bool,
+            wantCalledWriteCount: Int
+        )] = [
+            (
+                name: "expect a call to flush without suspension",
+                callSuspend: false,
+                wantCalledWriteCount: 1
+            ),
+            (
+                name: "expect no call to flush after suspension",
+                callSuspend: true,
+                wantCalledWriteCount: 0
+            )
+        ]
+
+        for test in tests {
+            let mwriter = MockWriter(shouldSuccess: true)
+            let output = BufferedOutput(writer: mwriter,
+                                        config: Config(flushEntryCount: 10,
+                                                       flushInterval: 1,
+                                                       retryRule: DefaultRetryRule(retryLimit: 1)))
+            output.start()
+
+            if test.callSuspend {
+                output.suspend()
+            }
+
+            output.emit(Entry("1".data(using: .utf8)!))
+
+            let afterExpectation = expectation(description: "after")
+            DispatchQueue.main.asyncAfter(deadline: .now() + 3.0) {
+                afterExpectation.fulfill()
+            }
+            wait(for: [afterExpectation], timeout: 4.0)
+            XCTAssertEqual(mwriter.calledWriteCount,
+                           test.wantCalledWriteCount,
+                           test.name)
+        }
+    }
+
+    func testResume() {
+        let tests: [(
+            name: String,
+            callResume: Bool,
+            wantCalledWriteCount: Int
+            )] = [
+                (
+                    name: "expect no call to flush without resumption",
+                    callResume: false,
+                    wantCalledWriteCount: 0
+                ),
+                (
+                    name: "expect a call to flush after resumption",
+                    callResume: true,
+                    wantCalledWriteCount: 1
+                )
+        ]
+
+        for test in tests {
+            let mwriter = MockWriter(shouldSuccess: true)
+            let output = BufferedOutput(writer: mwriter,
+                                        config: Config(flushEntryCount: 10,
+                                                       flushInterval: 1,
+                                                       retryRule: DefaultRetryRule(retryLimit: 1)))
+            output.start()
+            output.suspend()
+
+            if test.callResume {
+                output.resume()
+            }
+
+            output.emit(Entry("1".data(using: .utf8)!))
+
+            let afterExpectation = expectation(description: "after")
+            DispatchQueue.main.asyncAfter(deadline: .now() + 3.0) {
+                afterExpectation.fulfill()
+            }
+            wait(for: [afterExpectation], timeout: 4.0)
+            XCTAssertEqual(mwriter.calledWriteCount,
+                           test.wantCalledWriteCount,
+                           test.name)
+        }
+    }
 }
diff --git a/Demo/Demo/AppDelegate.swift b/Demo/Demo/AppDelegate.swift
@@ -30,4 +30,12 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         logger.post("6".data(using: .utf8)!)
         return true
     }
+
+    func applicationDidEnterBackground(_: UIApplication) {
+        logger.suspend()
+    }
+
+    func applicationWillEnterForeground(_: UIApplication) {
+        logger.resume()
+    }
 }