Skip to content

Commit 527cbc5

Browse files
committed
Revert of Support for :enabled selector on Anchor & Area elements (patchset #2 id:20001 of https://codereview.chromium.org/408293002/)
Reason for revert: HTML spec has been modified [1] to disable support for :enabled CSS selector on Anchor, Area & Link elements, after discussion on W3C Bugzilla [2]. [1] https://html5.org/r/8818 [2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=26622 Original issue's description: > Support for :enabled selector on Anchor & Area elements > > Updates the PseudoEnabled selector checker to check for Anchor & Area > elements with a link. Reverts ef7563d > which removed relevant Shadow DOM tests. > > Spec: http://html.spec.whatwg.org/#selector-enabled > > BUG=393105 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179427 TBR=esprehn@chromium.org,alexis.menard@intel.com,dglazkov@chromium.org,jchaffraix@chromium.org BUG=393105 Review URL: https://codereview.chromium.org/610683002 git-svn-id: svn://svn.chromium.org/blink/trunk@182932 bbb929c8-8fbe-4397-9dbb-9b2b20218538
1 parent 45b9b91 commit 527cbc5

6 files changed

+0
-96
lines changed

LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor-expected.html

-3
This file was deleted.

LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor.html

-22
This file was deleted.

LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-area-expected.html

-25
This file was deleted.

LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-area.html

-42
This file was deleted.

Source/core/css/SelectorChecker.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -787,8 +787,6 @@ bool SelectorChecker::checkOne(const SelectorCheckingContext& context, const Sib
787787
case CSSSelector::PseudoEnabled:
788788
if (element.isFormControlElement() || isHTMLOptionElement(element) || isHTMLOptGroupElement(element))
789789
return !element.isDisabledFormControl();
790-
else if (isHTMLAnchorElement(element) || isHTMLAreaElement(element))
791-
return element.isLink();
792790
break;
793791
case CSSSelector::PseudoFullPageMedia:
794792
return element.document().isMediaDocument();

Source/core/html/HTMLAnchorElement.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,6 @@ void HTMLAnchorElement::parseAttribute(const QualifiedName& name, const AtomicSt
195195
if (wasLink || isLink()) {
196196
pseudoStateChanged(CSSSelector::PseudoLink);
197197
pseudoStateChanged(CSSSelector::PseudoVisited);
198-
if (wasLink != isLink())
199-
pseudoStateChanged(CSSSelector::PseudoEnabled);
200198
}
201199
if (wasLink && !isLink() && treeScope().adjustedFocusedElement() == this) {
202200
// We might want to call blur(), but it's dangerous to dispatch

0 commit comments

Comments
 (0)