Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing: Use new create system with new publisher #1

Closed

Conversation

iLLiCiTiT
Copy link
Member

Recreated PR from ynput/ayon-core#87

Not sure how much value the changes have as were done before ayon-python-api and most of the code still uses OpenPype naming.

…sher

# Conflicts:
#	server_addon/hiero/client/ayon_hiero/api/pipeline.py
#	server_addon/hiero/client/ayon_hiero/api/plugin.py
#	server_addon/hiero/client/ayon_hiero/api/startup/Python/Startup/Startup.py
#	server_addon/hiero/client/ayon_hiero/plugins/create/create_shot_clip.py
#	server_addon/hiero/client/ayon_hiero/plugins/create/create_workfile.py
#	server_addon/hiero/client/ayon_hiero/plugins/publish/collect_otio_timeline.py
#	server_addon/hiero/client/ayon_hiero/plugins/publish/collect_workfile.py
#	server_addon/hiero/client/ayon_hiero/plugins/publish/extract_workfile.py
#	server_addon/hiero/client/ayon_hiero/plugins/publish/precollect_workfile.py
@iLLiCiTiT iLLiCiTiT force-pushed the feature/OP-6465_hiero_update_to_new_publisher branch from 627640b to 7f42b19 Compare June 27, 2024 15:48
@mkolar mkolar added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Aug 7, 2024
@robin-ynput
Copy link
Contributor

@iLLiCiTiT I'm started on this task again and going to use this PR as a reference.
Reviewing-wise, what should we do with this one ? Shall I tweak it into a working version or do you want me to close it and start from fresh ?

@iLLiCiTiT
Copy link
Member Author

@iLLiCiTiT I'm started on this task again and going to use this PR as a reference.
Reviewing-wise, what should we do with this one ? Shall I tweak it into a working version or do you want me to close it and start from fresh ?

As description says, it is recreation of ynput/ayon-core#87 which was not created by me.

I don't know how outdated the PR is, but it looks like it is. Some parts can be re-used, e.g. HieroHost, but it looks like some changes made it more OpenPype-like. So from my point of view, you can start over and copy-paste what is useful from here.

@jakubjezek001
Copy link
Member

Shall I tweak it into a working version or do you want me to close it and start from fresh ?

Looking quickly into the code and it seems to me that it was adaptation of the ynput/ayon-resolve#3. But Ultimatelly this should look more like ynput/ayon-resolve#15 anyway so it is really up to you what way you will go.

@robin-ynput
Copy link
Contributor

OK, well I've branched off this one so far which got me to a promising state. So I'll likely continue from there.

@iLLiCiTiT
Copy link
Member Author

Closing in favor of #14 .

@iLLiCiTiT iLLiCiTiT closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants