-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USD contribution: Set up different default values based on profiles #973
base: develop
Are you sure you want to change the base?
Conversation
…ancement/attributes_by_families
Hey,
Note I made a draft PR ynput/ayon-houdini#148 to show case my test for this PR. (It shows the issue of the difference between product type and families as mentioned here #973 (comment). but, it doesn't leverage this PR), so, I tried one more time. This example show cases the benefit from this PR.
The draft PRs where I took this screengrab are: ynput/ayon-houdini#149, ynput/ayon-deadline#54 |
families
instead of only productType
…ancement/attributes_by_families
Nevermind I just saw in description it is meant to be based on settings. But does it make sense to have it in settings? How someone, non-developer, will be able to fill the values correctly? |
Basically by "product type" (which is the profile) define the defaults for the attributes. Somewhat similar to what the Collect Job Info now does in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can hardly remember what this PR was about. (I can only remember that we used to have a big PR which we eventually split)
But, it seems to affect only extract_usd_layer_contributions.py
publish plugin.
So, I think we may need to rename this PR.
(anyways, this PR seems to work.)
I think the PR title is correct- just the branch name on my repo is still confusing, sorry about that :) |
Changelog Description
Follow up PR to: #994 so that USD products will use different attribute defaults based on profiles.
Additional info
TODO
Testing notes: