Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [clip_media] reviewable. #1112

Merged

Conversation

robin-ynput
Copy link
Contributor

Changelog Description

While working on retimes, I realized I've over-engineered the logic to handle [clip_media] reviewable.
When selected the reviewable should be otio_clip original media source range + handles.

This change simplify the approach to make it leverage collect_otio_review, extract_otio_review and extract_review.

Changes:

  • Rework [clip_media] logic to make it go through collect_otio_review
  • Ensure single frame reviewables are properly handled by extract_review plugins

Testing notes:

  1. From Flame or Hiero publish shot clip with the [clip_media] reviewable enabled
  2. Ensure reviewable is properly produce from clip source range (no retime applied) + handles

@ynbot ynbot added size/XS type: bug Something isn't working labels Jan 29, 2025
@robin-ynput robin-ynput self-assigned this Jan 29, 2025
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm!

@jakubjezek001 jakubjezek001 merged commit 41739bd into bugfix/tw_first_frame_offset Jan 30, 2025
13 checks passed
@jakubjezek001 jakubjezek001 deleted the bugfix/fix_clip_media_reviewable branch January 30, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants