Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7063 Fix Version follow up from Workfile set by hosts. #1111

Merged

Conversation

robin-ynput
Copy link
Contributor

Changelog Description

resolve: ynput/ayon-hiero#19

Initial requests was to be able to "disable" the workfile-version-follow-up feature per host.
The setting to enable this feature is ayon+settings://core/publish/CollectSceneVersion/hosts.

I realized there already was a settings to discriminate the workfile version collection per host: ayon+settings://core/publish/CollectSceneVersion/hosts

Changes:

  • Ensure that ayon+settings://core/publish/CollectSceneVersion/hosts is used in collect_scene_version
  • Report this in the {version} template computation for staging directory

Testing notes:

  1. Enable the version follow-up from ayon+settings://core/publish/CollectSceneVersion/hosts
    2a. Ensure it follows workfile version if the host is part of ayon+settings://core/publish/CollectSceneVersion/hosts
    2b. Ensure it does NOT follow workfile version otherwise

Tested in Hiero and Nuke (with/without staging directory).

@ynbot
Copy link
Contributor

ynbot commented Jan 29, 2025

Task linked: AY-7063 Hiero disable Version follow up

@ynbot ynbot added type: bug Something isn't working size/XS labels Jan 29, 2025
@robin-ynput robin-ynput added host: cross sponsored This is directly sponsored by a client or community member and removed size/XS labels Jan 29, 2025
@robin-ynput robin-ynput self-assigned this Jan 29, 2025
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - but aside of some minor cosmetic notes looks good to me!

@robin-ynput robin-ynput merged commit 7ef1b52 into develop Feb 3, 2025
1 check passed
@robin-ynput robin-ynput deleted the bugfix/AY-7063_disable_version_followup_per_host branch February 3, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AY-7063_Hiero disable Version follow up
4 participants