-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AY-7063 Fix Version follow up from Workfile set by hosts. #1111
Merged
robin-ynput
merged 6 commits into
develop
from
bugfix/AY-7063_disable_version_followup_per_host
Feb 3, 2025
Merged
AY-7063 Fix Version follow up from Workfile set by hosts. #1111
robin-ynput
merged 6 commits into
develop
from
bugfix/AY-7063_disable_version_followup_per_host
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: AY-7063 Hiero disable Version follow up |
robin-ynput
added
host: cross
sponsored
This is directly sponsored by a client or community member
and removed
size/XS
labels
Jan 29, 2025
BigRoy
reviewed
Jan 29, 2025
BigRoy
reviewed
Jan 29, 2025
iLLiCiTiT
reviewed
Jan 29, 2025
BigRoy
reviewed
Jan 29, 2025
BigRoy
reviewed
Jan 29, 2025
BigRoy
reviewed
Jan 29, 2025
BigRoy
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test - but aside of some minor cosmetic notes looks good to me!
iLLiCiTiT
approved these changes
Feb 3, 2025
2 tasks
robin-ynput
deleted the
bugfix/AY-7063_disable_version_followup_per_host
branch
February 3, 2025 10:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
resolve: ynput/ayon-hiero#19
Initial requests was to be able to "disable" the workfile-version-follow-up feature per host.
The setting to enable this feature is
ayon+settings://core/publish/CollectSceneVersion/hosts
.I realized there already was a settings to discriminate the workfile version collection per host:
ayon+settings://core/publish/CollectSceneVersion/hosts
Changes:
ayon+settings://core/publish/CollectSceneVersion/hosts
is used incollect_scene_version
{version}
template computation for staging directoryTesting notes:
ayon+settings://core/publish/CollectSceneVersion/hosts
2a. Ensure it follows workfile version if the host is part of
ayon+settings://core/publish/CollectSceneVersion/hosts
2b. Ensure it does NOT follow workfile version otherwise
Tested in Hiero and Nuke (with/without staging directory).