Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the icon size in the stylesheet for * #1093

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 16, 2025

Changelog Description

Set the icon size in the stylesheet to avoid too big clunky icons in BorisFX Silhouette.

The sizes appeared the same in Fusion and Maya with this added to the stylesheet (no changes there)

Additional info

Might be worth testing some other integrations to see if icon sizes still look good.

Also, may be good to test on 4k High DPI scaling to see how it reacts with this. (It may need e.g. em instead of px?)

See (internal) private discussion

Here are the BEFORE (too big ones) in Silhouette:

big2
big
big3

and some screens from it being corrected:

ok2
ok1

That may help to pinpoint what may differ due to this.

Testing notes:

  1. Test whether workfiles, publisher, loader, etc. doesn't suddenly have odd button and icon sizes.

…BorisFX Silhouette.

The sizes appeared the same in Fusion and Maya with this added to the stylesheet (no changes there)
@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Jan 16, 2025
@BigRoy BigRoy self-assigned this Jan 16, 2025
@ynbot ynbot added type: bug Something isn't working size/XS labels Jan 16, 2025
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove BorisFX Silhouette from the comment, it's not just for the dcc.

BigRoy and others added 2 commits January 21, 2025 12:20
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@BigRoy BigRoy merged commit 50de779 into ynput:develop Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants