Cosmetics + minor optimization for CleanUp plugin
#1086
Conversation
- Use `PublishError` instead of assertion - Optimize the 'check for errors' - Optimize the product type check + log debug message when skipped due to that - Move imports to top
BigRoy
added
community
| @@ -71,10 +72,12 @@ def process(self, instance): | |||
| self.log.debug("Cleaning renders new...") | |||
| self.clean_renders(instance, skip_cleanup_filepaths) | |||
|
|
|||
| if [ef for ef in self.exclude_families | |||
| if instance.data["productType"] in ef]: | |||
| product_type = instance.data["productType"] | |||
There was a problem hiding this comment.
Oh lord, this plugin...
This condition should probably happen before error checks. And we should change exclude_families to exclude_product_types.
I don't know why there was "str in str" check instead of "str == str"? I guess that is question for @jakubjezek001 who might be able to tell if there are product types that should be skipped too and contain "clip"?
There was a problem hiding this comment.
Oh lord, this plugin...
Thank for sharing my feelings 🙉 🙈 🙊
There was a problem hiding this comment.
I don't remember it anymore.. Its been reeeealy old code. But there could be case, or rather used to be, where render in nuke was render.local, render.farm and so on..
There was a problem hiding this comment.
So it should be safe to replace with explicit product type check...?
There was a problem hiding this comment.
So it should be safe to replace with explicit product type check...?
I am just guessing but it might be a solution.
Changelog Description
PublishErrorinstead of assertionclipyet the product type of the instance wasshotcliporclippyorclip.audiobecause it'd check if the string was IN the product type, it didn't check for exact match (which it does now)Additional info
n/a
Testing notes: