Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment workfile even when no unsaved changes #1054

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Increment workfile even when no unsaved changes #1054

merged 2 commits into from
Dec 17, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Dec 15, 2024

Changelog Description

Always increment workfile when requested - instead of only when no unsaved changes

Additional info

Fixes ynput/ayon-blender#86
But also changes the same behavior for Maya and Blender.

Testing notes:

  1. Version up workfile menu entry should increment workfile even when no unsaved changes

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Dec 15, 2024
@BigRoy BigRoy self-assigned this Dec 15, 2024
@ynbot ynbot added the size/XS label Dec 15, 2024
@BigRoy BigRoy mentioned this pull request Dec 15, 2024
Merged
moonyuet
moonyuet approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

LiborBatek
LiborBatek approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been tested both with the menu entry and via shortcut keys and both were working nicely!

image

LGTM!

@BigRoy BigRoy merged commit 50850b1 into ynput:develop Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@BigRoy BigRoy

Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version Up Workfile in Blender does not always increment
4 participants
@BigRoy @moonyuet @LiborBatek @ynbot