-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added return types for methods in models #547
base: master
Are you sure you want to change the base?
Conversation
Erkinbek
commented
Feb 12, 2024
•
edited
Loading
edited
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | Added method return types |
PR Summary
|
@@ -310,9 +310,12 @@ public function generate() | |||
'relationsClassHints' => $this->generateRelationsClassHints($tableRelations, $this->generateQuery), | |||
'enum' => $this->getEnum($tableSchema->columns), | |||
]; | |||
|
|||
$template = phpversion() < '7' ? 'model.php': 'model_from_7.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$template = phpversion() < '7' ? 'model.php': 'model_from_7.php'; | |
$template = phpversion() < '7' ? 'model.php': 'model_with_types.php'; |
Overall it's a good idea. |
@Erkinbek do you have time to fix the naming? |