Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Remove no-untyped-def from disabled error codes #621

Merged
merged 2 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions authx/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


async def _get_token_from_headers(
request: Request, config: AuthXConfig, refresh: bool = False, **kwargs
request: Request, config: AuthXConfig, refresh: bool = False, **kwargs: Any
) -> RequestToken:
"""Get access token from headers"""
# Get Header
Expand All @@ -28,7 +28,7 @@ async def _get_token_from_headers(


async def _get_token_from_cookies(
request: Request, config: AuthXConfig, refresh: bool = False, **kwargs
request: Request, config: AuthXConfig, refresh: bool = False, **kwargs: Any
) -> RequestToken:
"""Get access token from cookies

Expand Down Expand Up @@ -82,7 +82,7 @@ async def _get_token_from_cookies(


async def _get_token_from_query(
request: Request, config: AuthXConfig, refresh: bool = False, **kwargs
request: Request, config: AuthXConfig, refresh: bool = False, **kwargs: Any
) -> RequestToken:
query_token = request.query_params.get(config.JWT_QUERY_STRING_NAME)
if query_token is None:
Expand All @@ -94,7 +94,7 @@ async def _get_token_from_query(


async def _get_token_from_json(
request: Request, config: AuthXConfig, refresh: bool = False, **kwargs
request: Request, config: AuthXConfig, refresh: bool = False, **kwargs: Any
) -> RequestToken:
if request.headers.get("content-type") != "application/json":
raise MissingTokenError("Invalid content-type. Must be application/json")
Expand Down Expand Up @@ -132,7 +132,7 @@ async def _get_token_from_request(
config: AuthXConfig,
refresh: bool = False,
locations: Optional[TokenLocations] = None,
**kwargs,
**kwargs: Any,
) -> RequestToken:
errors: List[MissingTokenError] = []

Expand Down
28 changes: 17 additions & 11 deletions authx/dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ def __init__(
self._security = _from

@property
def request(self):
def request(self) -> Request:
return self._request

@property
def response(self):
def response(self) -> Response:
return self._response

def create_access_token(
Expand All @@ -35,8 +35,8 @@ def create_access_token(
expiry: Optional[DateTimeExpression] = None,
data: Optional[Dict[str, Any]] = None,
audience: Optional[StringOrSequence] = None,
*args,
**kwargs,
*args: Any,
**kwargs: Any,
) -> str:
return self._security.create_access_token(
uid, fresh, headers, expiry, data, audience, *args, **kwargs
Expand All @@ -57,26 +57,32 @@ def create_refresh_token(
)

def set_access_cookies(
self, token, response: Optional[Response] = None, max_age: Optional[int] = None
):
self,
token: str,
response: Optional[Response] = None,
max_age: Optional[int] = None,
) -> None:
self._security.set_access_cookies(
token=token, response=(response or self._response), max_age=max_age
)

def set_refresh_cookies(
self, token, response: Optional[Response] = None, max_age: Optional[int] = None
):
self,
token: str,
response: Optional[Response] = None,
max_age: Optional[int] = None,
) -> None:
self._security.set_refresh_cookies(
token=token, response=(response or self._response), max_age=max_age
)

def unset_access_cookies(self, response: Optional[Response] = None):
def unset_access_cookies(self, response: Optional[Response] = None) -> None:
self._security.unset_access_cookies(response=(response or self._response))

def unset_refresh_cookies(self, response: Optional[Response] = None):
def unset_refresh_cookies(self, response: Optional[Response] = None) -> None:
self._security.unset_access_cookies(response=(response or self._response))

def unset_cookies(self, response: Optional[Response] = None):
def unset_cookies(self, response: Optional[Response] = None) -> None:
self._security.unset_cookies(response=(response or self._response))

async def get_current_subject(self) -> Optional[T]:
Expand Down
18 changes: 9 additions & 9 deletions authx/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def _create_payload(
expiry: Optional[DateTimeExpression] = None,
data: Optional[Dict[str, Any]] = None,
audience: Optional[StringOrSequence] = None,
**kwargs,
**kwargs: Any,
) -> TokenPayload:
# Handle additional data
if data is None:
Expand Down Expand Up @@ -128,7 +128,7 @@ def _create_token(
expiry: Optional[DateTimeExpression] = None,
data: Optional[Dict[str, Any]] = None,
audience: Optional[StringOrSequence] = None,
**kwargs,
**kwargs: Any,
) -> str:
payload = self._create_payload(
uid=uid,
Expand Down Expand Up @@ -167,8 +167,8 @@ def _set_cookies(
type: str,
response: Response,
max_age: Optional[int] = None,
*args,
**kwargs,
*args: Any,
**kwargs: Any,
) -> None:
if type == "access":
token_key = self.config.JWT_ACCESS_COOKIE_NAME
Expand Down Expand Up @@ -394,8 +394,8 @@ def create_access_token(
expiry: Optional[DateTimeExpression] = None,
data: Optional[Dict[str, Any]] = None,
audience: Optional[StringOrSequence] = None,
*args,
**kwargs,
*args: Any,
**kwargs: Any,
) -> str:
"""Generate an Access Token

Expand Down Expand Up @@ -427,8 +427,8 @@ def create_refresh_token(
expiry: Optional[DateTimeExpression] = None,
data: Optional[Dict[str, Any]] = None,
audience: Optional[StringOrSequence] = None,
*args,
**kwargs,
*args: Any,
**kwargs: Any,
) -> str:
"""Generate a Refresh Token

Expand Down Expand Up @@ -610,7 +610,7 @@ def token_required(
Callable[[Request], TokenPayload]: Dependency for Valid token Payload retrieval
"""

async def _auth_required(request: Request):
async def _auth_required(request: Request) -> Any:
return await self._auth_required(
request=request,
type=type,
Expand Down
3 changes: 0 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,6 @@ exclude_lines = [
strict = true
warn_return_any = false
no_implicit_optional = false
disable_error_code = [
"no-untyped-def",
]

[[tool.mypy.overrides]]
module = "authx._internal._callback"
Expand Down
Loading