Please, use this guidelines as a recommendation for pull requests reviewing.
-
Checkout the branch and run the project locally to see all the changes live.
-
Check for unit and integration tests. If you accept the PR, then you are in charge of adding tests for the author ;)
-
Run unit and integration tests.
-
Try to finish all relevant PR reviews before lunch (13:00).
-
Try to make an in-person reviews. If the author is free, ask him to sit and go through all the comments together.
-
Leave meaningful comments even if you make an in-person review with PR's author. In this case other reviewer will know the result of your discussions.
-
Leave a resolution comments like
LGTM,Ship it!,Fix issues and merge.
-
If your PR is blocking you from furhter progress, send a direct message to all relevant Reviewers via Slack.
-
Think about good and clear PR description.
-
Mention all those people who must see the PR with github mentions:
@reviewer. -
If you see a comment like
Fix issues & merge, then you are free to merge the changes yourself after fixing all the issues.
The last reviewer merges the changes, unless it is explicitly stated that author should fix commented issues or merge the PR himself.