bug: Utils.has does not work as expected for non-lazy users

[JeanMertz]

Describe the bug

The implementation of Utils.has is as follows:

avante.nvim/lua/avante/utils/init.lua

Lines 25 to 32 in 078e931

	---Check if a plugin is installed
	---@param plugin string
	---@return boolean
	M.has = function(plugin)
	local ok, LazyConfig = pcall(require, "lazy.core.config")
	if ok then return LazyConfig.plugins[plugin] ~= nil end
	return package.loaded[plugin] ~= nil
	end

For non-lazy.nvim users this checks if the provided module is part of the package.loaded table.

However, a module is only inserted into this table after it has been required, but it's possible that avante.nvim is loaded before the specified module to has has been required, but that module might still be in the runtimepath and thus is accessible if needed.

I believe :h runtime-search-path provides a better alternative, specifically:

-- List all runtime dirs and packages with Lua paths.
nvim_get_runtime_file("lua/", v:true)

To reproduce

No response

Expected behavior

No response

Installation method

n/a

Environment

n/a

Repro

No response

[JeanMertz]

I should note, I ran into this due to :checkhealth throwing errors that weren't accurate:

avante.nvim/lua/avante/health.lua

Lines 9 to 23 in f7b5173

	-- Required dependencies
	local required_plugins = {
	["nvim-treesitter"] = "nvim-treesitter/nvim-treesitter",
	["dressing.nvim"] = "stevearc/dressing.nvim",
	["plenary.nvim"] = "nvim-lua/plenary.nvim",
	["nui.nvim"] = "MunifTanjim/nui.nvim",
	}
	for plugin_name, plugin_path in pairs(required_plugins) do
	if Utils.has(plugin_name) then
	H.ok(string.format("Found required plugin: %s", plugin_path))
	else
	H.error(string.format("Missing required plugin: %s", plugin_path))
	end
	end