feat(contract): withdraw_from_service_manager in BatcherPaymentService.sol #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
JuArce
reviewed
Feb 10, 2025
| userData[msg.sender].balance += msg.value; | ||
| userData[msg.sender].unlockBlockTime = 0; | ||
| emit PaymentReceived(msg.sender, msg.value); | ||
| if (msg.sender != address(alignedLayerServiceManager)) { // `alignedLayerServiceManager.withdraw()` triggers `receive()` (and with only 2300 gas) |
There was a problem hiding this comment.
@MauroToscano does it make sense to you?
There was a problem hiding this comment.
Uri mentioned it doesn't work without that, you can try just in case
JuArce
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withdraw_from_service_manager in BatcherPaymentService.sol
Description
AlignedLayerServiceManager has a
withdraw()function, which is currently not accesible to the Batcher, since he pays through the BatcherPaymentService.With this function, the Batcher will be able to withdraw funds from AlignedLayerServiceManager.
How to Test
Addresses:
balanceOfbatcherPaymentServiceonAlignedLayerServiceManagerNote: The anvil deployment script already funds the Batcher balance with 1ETH
The output should be
The batcherPaymentService owner is
0x14dC79964da2C08b23698B3D3cc7Ca32193d9955, and it private key is0x4bbbf85ce3377467afe5d46f804f221813b2bb87f24d81f60f1fcdbf7cbf4356(Address 7 in anvil)AlignedLayerServiceManagerThe output should be
The output should be
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging