Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): use correct verifyBatchInclusion function and update python scripts on examples/verify #1795

Open
JuArce opened this issue Feb 11, 2025 · 0 comments · May be fixed by #1796
Open
Assignees

Comments

@JuArce
Copy link
Collaborator

JuArce commented Feb 11, 2025

Description

The example available in examples/verify uses the deprecated verifyBatchInclusion function which does not receive senderAddress. It should use the following function

function verifyBatchInclusion(
        bytes32 proofCommitment,
        bytes32 pubInputCommitment,
        bytes32 provingSystemAuxDataCommitment,
        bytes20 proofGeneratorAddr,
        bytes32 batchMerkleRoot,
        bytes memory merkleProof,
        uint256 verificationDataBatchIndex,
        address senderAddress
    ) external view onlyWhenNotPaused(2) returns (bool) {
...
}

Also, the python scripts to generate the verification data does not work. It uses an old version of the encoded data file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant