Skip to content

fix: report location in use-baseline #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

fix: report location in use-baseline #314

merged 1 commit into from
Apr 6, 2025

Conversation

yeonjuan
Copy link
Owner

@yeonjuan yeonjuan commented Apr 6, 2025

fixes #313

AS-IS

스크린샷 2025-04-06 오후 6 00 38

TO-Be

스크린샷 2025-04-06 오후 6 00 04

Copy link
Contributor

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yeonjuan yeonjuan merged commit 75e602e into main Apr 6, 2025
5 checks passed
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (a5d65ce) to head (0a368a5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          72       72           
  Lines        2123     2123           
  Branches      574      574           
=======================================
  Hits         2097     2097           
  Misses         26       26           
Flag Coverage Δ
unittest 98.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/lib/rules/use-baseline.js 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[use-baseline] For unavailable attribute value warnings, set the character position to the start of value
2 participants