Skip to content

Improve use-baseline to cover more cases. #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
yeonjuan opened this issue Apr 8, 2025 · 2 comments · Fixed by #318
Closed
4 tasks done

Improve use-baseline to cover more cases. #316

yeonjuan opened this issue Apr 8, 2025 · 2 comments · Fixed by #318
Assignees
Labels
enhancement New feature or request

Comments

@yeonjuan
Copy link
Owner

yeonjuan commented Apr 8, 2025

We intentionally removed some of the bcd data when adding the use-baseline rules. (comment)

However, some of the removed data could be used to cover additional cases.

  • input.type_*
input.type_button
input.type_checkbox
...
input.type_week
  • a.href.href_sms
  • th.rowspan.rowspan_zero
  • td.rowspan.rowspan_zero
@yeonjuan yeonjuan added the enhancement New feature or request label Apr 8, 2025
@yeonjuan yeonjuan self-assigned this Apr 8, 2025
@yeonjuan
Copy link
Owner Author

Hi @rviscomi This improvement has been deployed.
I improved the use-baseline rule to check for features with underbar (“_”) as a key value, which were previously excluded. It requires a bit of hard coding, but we can raise the coverage as much as possible.

Image

@rviscomi
Copy link
Contributor

Very nice! Goes to show that underlined keys are more useful than I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants