From 1deb81a34a877fe7562d55caeba82594cd345522 Mon Sep 17 00:00:00 2001 From: Yegor Bugayenko Date: Sun, 12 May 2024 11:47:20 -0400 Subject: [PATCH] #5 test works --- .rubocop.yml | 2 ++ lib/judges/pack.rb | 16 +++++----------- lib/judges/packs.rb | 1 - lib/judges/test.rb | 1 - lib/judges/update.rb | 1 - test/test_judges.rb | 1 - test/test_pack.rb | 1 - test/test_packs.rb | 1 - test/test_test.rb | 1 - test/test_update.rb | 1 - 10 files changed, 7 insertions(+), 19 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index a1a4eb0..3587acc 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -27,6 +27,8 @@ AllCops: SuggestExtensions: false NewCops: enable +Style/GlobalVars: + Enabled: false Metrics/MethodLength: Enabled: false Gemspec/RequiredRubyVersion: diff --git a/lib/judges/pack.rb b/lib/judges/pack.rb index 05d0c4b..697f667 100644 --- a/lib/judges/pack.rb +++ b/lib/judges/pack.rb @@ -1,4 +1,3 @@ -#!/usr/bin/env ruby # frozen_string_literal: true # Copyright (c) 2014-2024 Yegor Bugayenko @@ -36,10 +35,12 @@ def initialize(dir) end # Run it with the given Factbase and environment variables. - def run(fb, env) - $fb = fb + def run(fbase, env) + $fb = fbase env.each do |k, v| - eval("$#{k} = '#{v}'") + # rubocop:disable Security/Eval + eval("$#{k} = '#{v}'", binding, __FILE__, __LINE__) # $foo = 42 + # rubocop:enable Security/Eval end s = File.join(@dir, script) raise "Can't load '#{s}'" unless File.exist?(s) @@ -57,11 +58,4 @@ def tests YAML.load_file(f) end end - - # Iterate over .yml tests. - def tests - Dir.glob(File.join(@dir, '*.yml')).map do |f| - YAML.load_file(f) - end - end end diff --git a/lib/judges/packs.rb b/lib/judges/packs.rb index 28c1e5d..598ead3 100644 --- a/lib/judges/packs.rb +++ b/lib/judges/packs.rb @@ -1,4 +1,3 @@ -#!/usr/bin/env ruby # frozen_string_literal: true # Copyright (c) 2014-2024 Yegor Bugayenko diff --git a/lib/judges/test.rb b/lib/judges/test.rb index 60a5852..4639279 100644 --- a/lib/judges/test.rb +++ b/lib/judges/test.rb @@ -1,4 +1,3 @@ -#!/usr/bin/env ruby # frozen_string_literal: true # Copyright (c) 2014-2024 Yegor Bugayenko diff --git a/lib/judges/update.rb b/lib/judges/update.rb index 8e1c2bb..3cfcc0d 100644 --- a/lib/judges/update.rb +++ b/lib/judges/update.rb @@ -1,4 +1,3 @@ -#!/usr/bin/env ruby # frozen_string_literal: true # Copyright (c) 2014-2024 Yegor Bugayenko diff --git a/test/test_judges.rb b/test/test_judges.rb index db93a58..88b349d 100644 --- a/test/test_judges.rb +++ b/test/test_judges.rb @@ -1,6 +1,5 @@ # frozen_string_literal: true -# # Copyright (c) 2024 Yegor Bugayenko # # Permission is hereby granted, free of charge, to any person obtaining a copy diff --git a/test/test_pack.rb b/test/test_pack.rb index 1d8644f..77943c1 100644 --- a/test/test_pack.rb +++ b/test/test_pack.rb @@ -1,6 +1,5 @@ # frozen_string_literal: true -# # Copyright (c) 2024 Yegor Bugayenko # # Permission is hereby granted, free of charge, to any person obtaining a copy diff --git a/test/test_packs.rb b/test/test_packs.rb index d92ebbe..35b9dab 100644 --- a/test/test_packs.rb +++ b/test/test_packs.rb @@ -1,6 +1,5 @@ # frozen_string_literal: true -# # Copyright (c) 2024 Yegor Bugayenko # # Permission is hereby granted, free of charge, to any person obtaining a copy diff --git a/test/test_test.rb b/test/test_test.rb index 5a04356..2f0b4ce 100644 --- a/test/test_test.rb +++ b/test/test_test.rb @@ -1,6 +1,5 @@ # frozen_string_literal: true -# # Copyright (c) 2024 Yegor Bugayenko # # Permission is hereby granted, free of charge, to any person obtaining a copy diff --git a/test/test_update.rb b/test/test_update.rb index 7fcaa28..0a55740 100644 --- a/test/test_update.rb +++ b/test/test_update.rb @@ -1,6 +1,5 @@ # frozen_string_literal: true -# # Copyright (c) 2024 Yegor Bugayenko # # Permission is hereby granted, free of charge, to any person obtaining a copy