Skip to content

Commit 35edebf

Browse files
committed
make version check added
1 parent b33ab31 commit 35edebf

File tree

3 files changed

+44
-32
lines changed

3 files changed

+44
-32
lines changed

Makefile

+1
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export
6161
# Run a single step from ./steps
6262
define step
6363
set -e
64+
"${LOCAL}/help/check-make.sh"
6465
start=$$(date +%s%N)
6566
echo -e "\n\n\n+++ $(1) +++\n"
6667
source "$(LOCAL)/help/gnu-utils.sh"

README.md

-32
Original file line numberDiff line numberDiff line change
@@ -194,35 +194,3 @@ and run Docker as explained above.
194194
[create-PAT]: https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token
195195
[PAT]: https://docs.github.com/en/enterprise-server@3.9/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens
196196
[detached]: https://docs.docker.com/language/golang/run-containers/#run-in-detached-mode
197-
198-
## Troubleshooting
199-
200-
### macOS: Errors while using the default `make` utility
201-
202-
#### Error message
203-
204-
`bash: -c: line 2: syntax error: unexpected end of file`
205-
206-
#### Solution
207-
208-
Install the new version of `make` via Homebrew:
209-
210-
```bash
211-
brew install make
212-
```
213-
214-
Add GNU `make` to your `PATH`:
215-
216-
* On Apple Silicon Macs:
217-
218-
```bash
219-
PATH="/opt/homebrew/opt/make/libexec/gnubin:$PATH"
220-
```
221-
222-
* On Intel-based Macs:
223-
224-
```bash
225-
PATH="/usr/local/opt/make/libexec/gnubin:$PATH"
226-
```
227-
228-
### macOS: Outdated shell version

help/check-make.sh

+43
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
#!/usr/bin/env bash
2+
# The MIT License (MIT)
3+
#
4+
# Copyright (c) 2021-2024 Yegor Bugayenko
5+
#
6+
# Permission is hereby granted, free of charge, to any person obtaining a copy
7+
# of this software and associated documentation files (the "Software"), to deal
8+
# in the Software without restriction, including without limitation the rights
9+
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10+
# copies of the Software, and to permit persons to whom the Software is
11+
# furnished to do so, subject to the following conditions:
12+
#
13+
# The above copyright notice and this permission notice shall be included
14+
# in all copies or substantial portions of the Software.
15+
#
16+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18+
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
19+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22+
# SOFTWARE.
23+
24+
set -e
25+
set -o pipefail
26+
27+
make_version=$(make --version | head -n1 | cut -d' ' -f3)
28+
make_version_major=$(echo "${make_version}" | cut -d'.' -f1)
29+
30+
if [ "${make_version_major}" -lt 4 ]; then
31+
echo "Make version must be 4 or higher. Current: ${make_version}"
32+
if [ "${LOCAL}/help/is-macos.sh" ]; then
33+
echo "Use brew install make"
34+
if [ "$(uname -m)" = "arm64" ]; then
35+
echo "Make sure you have /opt/homebrew/opt/make/libexec/gnubin in your PATH"
36+
else
37+
echo "Make sure you have /usr/local/opt/make/libexec/gnubin in your PATH"
38+
fi
39+
else
40+
echo "Try to update it with sudo apt-get install make"
41+
fi
42+
exit 1
43+
fi

0 commit comments

Comments
 (0)