Consider both annotation - current field and parent #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvamelichev
requested changes
Jan 15, 2025
nvamelichev
requested changes
Jan 16, 2025
databind/src/main/java/tech/ydb/yoj/databind/schema/Column.java
Outdated
Show resolved
Hide resolved
nvamelichev
requested changes
Jan 16, 2025
databind/src/main/java/tech/ydb/yoj/databind/schema/naming/AnnotationFirstNamingStrategy.java
Outdated
Show resolved
Hide resolved
nvamelichev
requested changes
Jan 19, 2025
databind/src/main/java/tech/ydb/yoj/databind/schema/Column.java
Outdated
Show resolved
Hide resolved
Instead of the legacy YOJ 1.x and 2.x strategy that adds subobject column name as prefix for subobjects' column names **unless an explicit `Column#name()` annotation is set**, introduce two more consistent strategies: - Always add subobject column name as prefix (`ColumnNaming.RELATIVE`) - Never add subobject column name as prefix, treat subobject column as top-level (`ColumnNaming.ABSOLUTE`) with the more generally applicable `ColumnNaming.RELATIVE` strategy becoming the default in YOJ 3.0.
nvamelichev
force-pushed
the
consider-parent-column-annotation-if-child-present-117
branch
from
73c4aee to
8a5c2f7
Compare
nvamelichev
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of problem described here: #117