From 210060488edffb2fa67242fc634ba36b6bd45e49 Mon Sep 17 00:00:00 2001
From: yaza <wayan13yasa@gmail.com>
Date: Sun, 14 Apr 2024 15:31:38 +0800
Subject: [PATCH] clean response api

---
 README.md                    | 12 ++++++++----
 src/Traits/Response.php      |  6 +++---
 src/Traits/ResultService.php |  6 +++---
 3 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index 778720b..6195ac3 100644
--- a/README.md
+++ b/README.md
@@ -4,7 +4,7 @@ With easy repository, you can have the power of the repository pattern, without
 
 ## Requirement
 
-- Minimum PHP ^8.1
+- Minimum PHP ^8.2
 
 ## Installation
 
@@ -17,9 +17,13 @@ Specific Version :
 
 | Laravel Version |  Package Version   |
 |:---------------:|:------------------:|
-|       10        |        4.x         |
+|       11        |        5.x         |
+|       10        |        4.0         |
   | 9              | 3.2                |
 ```bash
+# for laravel 10
+$ composer require yaza/laravel-repository-service:"^4.0"
+# for laravel 9
 $ composer require yaza/laravel-repository-service:"^3.2"
 ```
 
@@ -50,8 +54,8 @@ php artisan make:service UserService
 // or
 php artisan make:service UserService --repository
 
-// create service for api template
-php artisan make:service UserService --api
+// create service with blank template
+php artisan make:service UserService --blank
 
 ```
 
diff --git a/src/Traits/Response.php b/src/Traits/Response.php
index 5470409..3a60e72 100644
--- a/src/Traits/Response.php
+++ b/src/Traits/Response.php
@@ -17,7 +17,7 @@ trait Response
      * @param null $code
      * @return \Illuminate\Http\JsonResponse
      */
-    public function responseJson($msg = '', $data = [], $code = null, $errors = [])
+    public function responseJson($msg = '', $data = [], $code = null, $errors = null)
     {
         if(is_null($code)){
             $http_code = 200;
@@ -25,11 +25,11 @@ public function responseJson($msg = '', $data = [], $code = null, $errors = [])
             $http_code = $code;
         }
 
-        return response()->json([
+        return response()->json(array_filter([
             'code' => $http_code,
             'message' => $msg,
             'data' => $data,
             'errors' => $errors
-        ], $http_code);
+        ]), $http_code);
     }
 }
diff --git a/src/Traits/ResultService.php b/src/Traits/ResultService.php
index 4c63434..eced6b6 100644
--- a/src/Traits/ResultService.php
+++ b/src/Traits/ResultService.php
@@ -13,7 +13,7 @@ trait ResultService
     private $data = null;
     private $message = null;
     private $code = null;
-    private $errors = [];
+    private $errors = null;
 
     /**
      * set data output
@@ -149,11 +149,11 @@ public function toJson()
             $http_code = $this->getCode();
         }
 
-        return response()->json([
+        return response()->json(array_filter([
             'code' => $http_code,
             'message' => $this->getMessage(),
             'data' => $this->getData(),
             'errors' => $this->getError(),
-        ], $http_code);
+        ]), $http_code);
     }
 }