Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explain why installation through NPM is not suggested #589

Open
BYK opened this issue Aug 1, 2017 · 4 comments
Open

Better explain why installation through NPM is not suggested #589

BYK opened this issue Aug 1, 2017 · 4 comments

Comments

@BYK
Copy link
Member

BYK commented Aug 1, 2017

This issue was brought up here: https://twitter.com/maybekatz/status/890320508813586433

We should do a better job of explaining why the preferred way of installing yarn is not via NPM or don't mention this at all if we don't have a good reason.

Right now I think the package signature verification aspect is important but I'd like to hear more to come up with a solid explanation.

@BYK
Copy link
Member Author

BYK commented Aug 1, 2017

Ping @bestander @arcanis @Daniel15 @kittens

@Daniel15
Copy link
Member

Daniel15 commented Aug 1, 2017

What's wrong with the current text?

Note: Installation of Yarn via npm is generally not recommended. When installing Yarn with Node-based package managers, the package is not signed, and the only integrity check performed is a basic SHA1 hash, which is a security risk when installing system-wide apps.

The only inaccuracy I see here is that newer versions of npm use SHA512 rather than SHA1. We can probably just change the text to say "basic hash" rather than specifying an exact hashing algorithm.

@BYK
Copy link
Member Author

BYK commented Aug 1, 2017

May be we can add a sentence about why signing is important?

@mi-na-bot
Copy link

Is the bit about the sha1 checksum even still true? Brief research suggests that npm 5 and up actually includes an sha512 hash when publishing packages. https://npm.community/t/sha1-vs-sha512-integrity/3416

Is there some other reason not to install yarn with npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants