Add Finder's FinderSpawnTab option #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Trevor, thanks that looks great! I'll just make a few minor comments |
yannbertrand
requested changes
Oct 28, 2024
docs/finder/finderspawntab.md
Outdated
| @@ -0,0 +1,47 @@ | |||
| --- | |||
| title: Open folders in new tab or new window | Finder | |||
There was a problem hiding this comment.
Suggested change
| title: Open folders in new tab or new window | Finder | |
| title: Open folders destination | Finder |
I believe shorter is better for page titles. Description explains it well
docs/finder/finderspawntab.md
Outdated
| content: Set whether folders open in a new tab or a new window | ||
| --- | ||
|
|
||
| # Open folders in new tab or new window |
There was a problem hiding this comment.
Suggested change
| # Open folders in new tab or new window | |
| # Open folders destination |
As it's also used for the sidebar title, I prefer it to be short and do not assume user prefers one or the other option.
| ```bash | ||
| defaults write com.apple.finder "FinderSpawnTab" -bool "true" && killall Finder | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Please feel free to add the screenshots you took:
Suggested change
| <img | |
| src="./images/finderspawntab/true.png" | |
| alt="Example output with value set to true" | |
| width="953" height="571" style="height: auto" | |
| /> | |
This helps a lot to understand!
| ```bash | ||
| defaults write com.apple.finder "FinderSpawnTab" -bool "false" && killall Finder | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Suggested change
| <img | |
| src="./images/finderspawntab/false.png" | |
| alt="Example output with value set to false" | |
| width="953" height="571" style="height: auto" | |
| /> | |
|
|
||
| ```bash | ||
| defaults delete com.apple.finder "FinderSpawnTab" && killall Finder | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ``` | |
| ## Set value from UI | |
| 1. Access Finder settings from macOS UI | |
| 2. Toggle "Open folders in tabs instead of new windows" value |
3 tasks
|
@yannbertrand Thanks! I've updated the branch to incorporate all of your requested changes. |
yannbertrand
approved these changes
Oct 29, 2024
|
Thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Finder's
FinderSpawnTaboption, which controls whether the Finder offers "Open in New Tab" (the default in recent macOS versions) or "Open in New Window" when interacting with folders.I've only tested option this under macOS Sonoma. I suspect that it's been consistent across the last several OS versions, but I can't directly confirm.
In Sonoma, this option can be controlled from the "General" tab in Finder Settings via the checkbox at the bottom:
It controls what happens if you hold
Cmdwhile double-clicking a folder, as well as the top option in the context menu for a folder:With
FinderSpawnTabenabled (the default)With
FinderSpawnTabdisabledPersonally, having folders open in a new tab drives me crazy because I often want to drag items between the parent and child folders. 😝
Love the project! Please let me know if you need anything else for this PR.