Wire up extrusionWidth and lineHeight used for building tube geometry
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiedeziel and the rest of your teammates on |
Merged
|
Visit the preview URL for this PR (updated for commit a093486): https://gcode-preview--pr227-10-15-width-and-heig-os8bhoel.web.app (expires Fri, 15 Nov 2024 03:31:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
sophiedeziel
changed the title
extrusionWidth and lineHeight brought back for building tube geometry
11 tasks
sophiedeziel
changed the title
extrusionWidth and lineHeight brought back for building tube geometryextrusionWidth and lineHeight used for building tube geometry
sophiedeziel
changed the title
extrusionWidth and lineHeight used for building tube geometryextrusionWidth and lineHeight used for building tube geometry
sophiedeziel
force-pushed
the
10-15-width-and-height-for-extrusions
branch
from
e0dcb92 to
a093486
Compare
This was referenced Oct 16, 2024
Merged
sophiedeziel
added a commit
that referenced
this pull request
Oct 19, 2024
sophiedeziel
added a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #221
As part of the
v3.xrefactor, several options were omitted in order to reimplement incrementally to keep the PR shorter.This PR is bringing back
extrusionWidthandlineHeight.