Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix homepage re-renders #712

Merged
merged 10 commits into from
Mar 20, 2025
Merged

chore: fix homepage re-renders #712

merged 10 commits into from
Mar 20, 2025

Conversation

printerscanner
Copy link
Member

  1. Ref-Based Progress Bar: replaced React state with a ref to directly update the progress bar width in the DOM.

  2. Isolated onComplete Callback: moved the onComplete logic into the ProgressBar component so the callback triggers when the progress bar completes.

  3. Removed Unnecessary State: Removed elapsed state and activeBarWidth calculation from ImageSliderItems. Progress bar logic is now fully encapsulated in the ProgressBar component.

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:12pm
reactflow-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:12pm
svelteflow-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:12pm
xyflow-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:12pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ui-components ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 8:12pm

@printerscanner printerscanner linked an issue Mar 19, 2025 that may be closed by this pull request
@printerscanner printerscanner changed the title Progress bar Fix Homepage Re-Renders Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home page has too much re-rendering going on
2 participants