Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home page has too much re-rendering going on #701

Closed
hichemfantar opened this issue Mar 14, 2025 · 3 comments · Fixed by #712
Closed

Home page has too much re-rendering going on #701

hichemfantar opened this issue Mar 14, 2025 · 3 comments · Fixed by #712

Comments

@hichemfantar
Copy link

Screen.Recording.2025-03-14.at.8.19.30.AM.mp4
@moklick
Copy link
Member

moklick commented Mar 17, 2025

Thanks! What is happening here? And why do we get those re-renders only in prod? We need to find out!

@hichemfantar
Copy link
Author

looks like it's caused by the progress bar in the Project Showcase section

@printerscanner printerscanner linked a pull request Mar 19, 2025 that will close this issue
chore: fix homepage re-renders #712
Merged
@hichemfantar
Copy link
Author

thanks for the fix @printerscanner i had a similar fix in mind, animations should almost always be handled with refs.

as for the reason it's only happening in prod, i think it's either a bug in react or the react dev tools. or there could be something else going on but i have no idea what it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix homepage re-renders xyflow/web
2 participants
@moklick @hichemfantar