Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide the ability to upload patches #78 #104
base: main
Are you sure you want to change the base?
Provide the ability to upload patches #78 #104
Changes from 12 commits
ed7f637
98b7d11
35e128e
8a1fa11
08c0385
3ae9403
6eed94f
673b65f
e94307a
ccf3a61
8e4e223
5b5f667
acd8a29
e0d487e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we should do this. If we do have multiple jobs with the same id, we should be mindful that only one upload job should run at a time. Im not sure what is the behaviour of the job manager/executor if you want to execute two jobs with the same id concurrently. If you can, the job logs will probably be overwritten in the permanent directory. The job progress might also act up.
On a second thought, one might not be interested to save ALL the logs of a potentially really big number of uploads (depends on your use case). If Admin tools is installed as root, it should be ok to have only one id for all the upload jobs. Otherwise, it might be better to have an id per wiki. But i still think we should take precaution and not run these jobs simultaneously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admin tools is used as root, and for the upload jobs that I'm creating I'm using the attachment reference and startTime of the job to create the job ID, this way the jobs are unique. If you think it would be safer to ensure that only one job at a time is running, I could create a general ID and check if there is any job running for said ID. The issue with this is that the logs will be overwritten. To prevent multiple jobs with the same file reference running at the same time, I'm using
JobGroupPath
which will prevent two jobs with the same file reference to run at the same time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand, you use this in order to manually save some markers that you later query and display a custom message.
You can do the following instead: