Minor Refactor, Add Periods

xsn34kzx · Jul 9, 2024 · c145998 · c145998
1 parent 4e48194
commit c145998
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/modifier/modifier-type.ts b/src/modifier/modifier-type.ts
@@ -1911,10 +1911,8 @@ export function getPlayerModifierTypeOptions(count: integer, party: PlayerPokemo
   }
 
   // Replace rolled options if any override entries are present
-  for (let i = 0; i < Overrides.ITEM_REWARD_OVERRIDE.length; i++) {
-    if (options.length <= i) {
-      break;
-    }
+  const minLength = Math.min(options.length, Overrides.ITEM_REWARD_OVERRIDE.length);
+  for (let i = 0; i < minLength; i++) {
     const override = Overrides.ITEM_REWARD_OVERRIDE[i];
     if (override.name in modifierTypes) {
       const modifierFunc = modifierTypes[override.name];

diff --git a/src/overrides.ts b/src/overrides.ts
@@ -122,7 +122,7 @@ export const MYSTERY_ENCOUNTER_OVERRIDE: MysteryEncounterType = null;
  * MODIFIER / HELD ITEM OVERRIDES
  */
 
-/** Override array of {@linkcode ModifierOverride}s used to provide modifiers to the player when starting a new game */
+/** Override array of {@linkcode ModifierOverride}s used to provide modifiers to the player when starting a new game. */
 export const STARTING_MODIFIER_OVERRIDE: ModifierOverride[] = [];
 /**
  * Override array of {@linkcode ModifierOverride}s used to provide modifiers to enemies.
@@ -131,9 +131,9 @@ export const STARTING_MODIFIER_OVERRIDE: ModifierOverride[] = [];
  */
 export const OPP_MODIFIER_OVERRIDE: ModifierOverride[] = [];
 
-/** Override array of {@linkcode ModifierOverride}s used to provide held items to first party member when starting a new game*/
+/** Override array of {@linkcode ModifierOverride}s used to provide held items to first party member when starting a new game. */
 export const STARTING_HELD_ITEMS_OVERRIDE: ModifierOverride[] = [];
-/** Override array of {@linkcode ModifierOverride}s used to provide held items to enemies on spawn */
+/** Override array of {@linkcode ModifierOverride}s used to provide held items to enemies on spawn. */
 export const OPP_HELD_ITEMS_OVERRIDE: ModifierOverride[] = [];
 
 /**