Attempt to resolve issues surrounding text value templates #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix xproc#1131 1. Make the backwards-incompatible change that TVTs are serialized as text, not XML, when they occur in content types that are not XML or HTML content types. 2. Correct the examples, observing that special case has to be taken with quotes in JSON. 3. Add explicit error (err:XD0052) for attempting to output a free-floating attribute node if the content type is not XML or HTML.
xatapult
approved these changes
Feb 4, 2025
xml-project
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1131
This one is ugly. We were very clear in the 3.0 spec that the serialization was XML, down to having examples that used it. But I persuaded myself that those examples would fail in the general case (because serialized XML could contain an unescaped double quote, making it an invalid JSON string) so this change is still an improvement.
I updated the example to show how to address this problem.
I decided to reuse
err:XD0052instead of addingerr:XD0084as I proposed in the issue. If we accept this PR, the tests in the test suite will need to be updated.