Attempt to clarify p:import-functions #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimsieke
approved these changes
Aug 28, 2024
xml-project
requested changes
Aug 29, 2024
There was a problem hiding this comment.
I am sorry to disagree with one aspect, but I think that functions imported in a p:library should not be automatically visible in a pipeline importing that library. As far as I can see, this break the current scoping rules for import.
If I want to use a function in a step, a p:import-function should be necessary to avoid scoping problems in the importing step.
|
Yes. I think you're absolutely right. I did note in the issue that I wasn't sure what the right answer was. Thanks for telling me :-) |
Sorry, I missed that question. |
xml-project
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1110