Tests cleaned up (#723)

* make scaffold test to work in strict mode by default

* feat: move boiler code uot for typeTypeResolvers specs

* eslint fixes

* feat: move boiler code out for mutation specs

* feat: move boiler code out for query specs

Co-authored-by: Jan Michael VIncent Trinidad <janmvtrinidad@gmail.com>

.eslintrc

@@ -1,6 +1,11 @@
 {
-    "extends": ["airbnb-base"],
+  "plugins": [
+    'jest',
+    'prettier'
+  ],
+    "extends": ["airbnb-base", 'prettier'],
     "rules": {
+      "prettier/prettier": "error",
       "no-console": "off",
       "global-require": "off",
       "no-plusplus": "off"

.prettierrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+    trailingComma: "all",
+    singleQuote: true,
+    printWidth: 120,
+    tabWidth: 2
+};

package.json

@@ -41,13 +41,16 @@
     "@typescript-eslint/parser": "^2.29.0",
     "eslint": "^5.5.0",
     "eslint-config-airbnb-base": "^13.1.0",
+    "eslint-config-prettier": "^7.2.0",
     "eslint-import-resolver-typescript": "^2.3.0",
     "eslint-plugin-import": "^2.14.0",
+    "eslint-plugin-jest": "^24.1.3",
+    "eslint-plugin-prettier": "^3.3.1",
     "jest": "^26.0.1",
-    "prettier": "^2.0.5",
+    "prettier": "^2.2.1",
+    "semantic-release": "^17.1.1",
     "testdouble": "^3.15.0",
-    "testdouble-jest": "^2.0.0",
-    "semantic-release": "^17.1.1"
+    "testdouble-jest": "^2.0.0"
   },
   "jest": {
     "testPathIgnorePatterns": [

templates/mutation.spec.handlebars

@@ -1,20 +1,16 @@
 import td from "testdouble";
-import { GqlContext, {{#if hasArguments}}Mutation{{toUpperCase mutationName}}Args{{/if}} } from "{{generatedPrefix}}/graphql/types";
-import { {{mutationName}}Mutation } from "./{{mutationName}}Mutation";
 
-const test{{mutationName}} = ({{#if hasArguments}}variables: Mutation{{toUpperCase mutationName}}Args, {{/if}}context: GqlContext) => {{mutationName}}Mutation({}, {{#if hasArguments}}variables{{else}}  {} {{/if}}, context, null)
+import { GqlContext, {{#if hasArguments}}Mutation{{toUpperCase mutationName}}Args,{{/if}} test{{toUpperCase mutationName}} } from "{{generatedPrefix}}/graphql/helpers/{{mutationName}}MutationSpecWrapper"
 
 
 test("{{mutationName}}", async () => {
 
 const context = td.object<GqlContext>();
-
     // td.when(context.{{moduleName}}Repository.findOne()).thenResolve()
-
     {{#if hasArguments}}
         const variables: Mutation{{toUpperCase mutationName}}Args = {}
     {{/if}}
 
-    const result = await test{{mutationName}}({{#if hasArguments}}variables,{{/if}} context);
+    const result = await test{{toUpperCase mutationName}}({{#if hasArguments}}variables,{{/if}} context);
 
     });

templates/mutationSpecWrapper.handlebars

@@ -0,0 +1,7 @@
+import { GraphQLResolveInfo } from 'graphql'
+import { GqlContext, {{#if hasArguments}}Mutation{{toUpperCase mutationName}}Args{{/if}} } from "{{generatedPrefix}}/graphql/types";
+import { {{mutationName}}Mutation } from "{{appPrefix}}/{{graphqlFileRootPath}}mutations/{{mutationName}}Mutation";
+
+export const test{{toUpperCase mutationName}} = ({{#if hasArguments}}variables: Mutation{{toUpperCase mutationName}}Args, {{/if}}context: GqlContext) => {{mutationName}}Mutation?.({}, {{#if hasArguments}}variables{{else}}  {} {{/if}}, context, {} as GraphQLResolveInfo)
+
+export type {GqlContext, {{#if hasArguments}}Mutation{{toUpperCase mutationName}}Args{{/if}} }

templates/query.spec.handlebars

@@ -1,10 +1,5 @@
 import td from "testdouble";
-import { GqlContext, {{#if hasArguments}}Query{{toUpperCase queryName}}Args{{/if}} } from "{{generatedPrefix}}/graphql/types";
-import { {{queryName}}Query } from "./{{queryName}}Query";
-
-
-const test{{queryName}} = ({{#if hasArguments}}variables: Query{{toUpperCase queryName}}Args,{{/if}} context: GqlContext) => {{queryName}}Query({}, {{#if hasArguments}}variables{{else}} {} {{/if}}, context, null)
-
+import { GqlContext, {{#if hasArguments}}Query{{toUpperCase queryName}}Args,{{/if}} test{{toUpperCase queryName}} } from "{{generatedPrefix}}/graphql/helpers/{{queryName}}QuerySpecWrapper"
 
 test("{{queryName}}", async () => {
 
@@ -16,6 +11,6 @@ test("{{queryName}}", async () => {
         const variables: Query{{toUpperCase queryName}}Args = {}
     {{/if}}
 
-    const result = await test{{queryName}}({{#if hasArguments}}variables,{{/if}} context);
+    const result = await test{{toUpperCase queryName}}({{#if hasArguments}}variables,{{/if}} context);
 
 });

templates/querySpecWrapper.handlebars

@@ -0,0 +1,9 @@
+import { GraphQLResolveInfo } from 'graphql'
+import { GqlContext, {{#if hasArguments}}Query{{toUpperCase queryName}}Args{{/if}} } from "{{generatedPrefix}}/graphql/types";
+import { {{queryName}}Query } from "{{appPrefix}}/{{graphqlFileRootPath}}queries/{{queryName}}Query";
+
+
+export const test{{toUpperCase queryName}} = ({{#if hasArguments}}variables: Query{{toUpperCase queryName}}Args,{{/if}} context: GqlContext) => {{queryName}}Query?.({}, {{#if hasArguments}}variables{{else}} {} {{/if}}, context, {} as GraphQLResolveInfo)
+
+
+export type {GqlContext, {{#if hasArguments}}Query{{toUpperCase queryName}}Args{{/if}} }

templates/typeTypeResolvers.spec.handlebars

@@ -1,22 +1,12 @@
 import td from "testdouble";
-
-import { GqlContext, ResolversParentTypes, {{#if hasArguments}}{{typeName}}{{capitalizedFieldName}}Args{{/if}} } from "{{generatedPrefix}}/graphql/types";
-import { {{typeName}}{{capitalizedFieldName}} } from "./{{typeName}}{{capitalizedFieldName}}";
-
-{{#if resolveReferenceType}}type ParentType = Parameters<typeof {{typeName}}{{capitalizedFieldName}}>[0];{{/if}}
-
-    const test{{typeName}}{{capitalizedFieldName}} = (parent: {{#if resolveReferenceType}}ParentType{{else}}ResolversParentTypes["{{typeName}}"]{{/if}}, {{#if hasArguments}}variables: {{typeName}}{{capitalizedFieldName}}Args,{{/if}} context: GqlContext) => {{typeName}}{{capitalizedFieldName}}(parent, {{#unless resolveReferenceType}}{{#if hasArguments}}variables{{else}} {} {{/if}},{{/unless}} context, null)
-
+import { GqlContext, ResolversParentTypes, test{{typeName}}{{capitalizedFieldName}} } from "{{generatedPrefix}}/graphql/helpers/{{typeName}}{{capitalizedFieldName}}SpecWrapper"
 
 test("{{typeName}}{{capitalizedFieldName}}", async () => {
-
 const context = td.object<GqlContext>();
-
     // td.when(context.{{moduleName}}Repository.findOne()).thenResolve()
-
-    const parent{{#if resolveReferenceType}} = {} as ParentType {{else}}: ResolversParentTypes["{{typeName}}"] = {}{{/if}}
+    const parent{{#if resolveReferenceType}} = {} as ParentType {{else}} = {} as ResolversParentTypes["{{typeName}}"]{{/if}}
     {{#if hasArguments}}
-        const variables: {{typeName}}{{capitalizedFieldName}}Args = {}
+        const variables = {} as {{typeName}}{{capitalizedFieldName}}Args
     {{/if}}
 
     const result = await test{{typeName}}{{capitalizedFieldName}}(parent, {{#if hasArguments}}variables,{{/if}} context);

templates/typeTypeResolversSpecWrapper.handlebars

@@ -0,0 +1,9 @@
+import { GraphQLResolveInfo } from 'graphql'
+import type { GqlContext, ResolversParentTypes, {{#if hasArguments}}{{typeName}}{{capitalizedFieldName}}Args{{/if}} } from "{{generatedPrefix}}/graphql/types";
+import { {{typeName}}{{capitalizedFieldName}} } from "{{appPrefix}}/{{graphqlFileRootPath}}types/{{typeName}}{{capitalizedFieldName}}";
+
+{{#if resolveReferenceType}}type ParentType = Parameters<typeof {{typeName}}{{capitalizedFieldName}}>[0];{{/if}}
+
+export const test{{typeName}}{{capitalizedFieldName}} = (parent: {{#if resolveReferenceType}}ParentType{{else}}ResolversParentTypes["{{typeName}}"]{{/if}}, {{#if hasArguments}}variables: {{typeName}}{{capitalizedFieldName}}Args,{{/if}} context: GqlContext) => {{typeName}}{{capitalizedFieldName}}?.({...parent, __typename: '{{typeName}}'}, {{#unless resolveReferenceType}}{{#if hasArguments}}variables{{else}} {} {{/if}},{{/unless}} context, {} as GraphQLResolveInfo)
+
+export type {GqlContext, ResolversParentTypes}