-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split config to multiple modules #1025
base: master
Are you sure you want to change the base?
Conversation
@JianMinTang Convert your pr to draft since CI failed |
Hi @bsbds, when I use |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
- Coverage 75.55% 75.26% -0.29%
==========================================
Files 180 204 +24
Lines 26938 28859 +1921
Branches 26938 28859 +1921
==========================================
+ Hits 20353 21722 +1369
- Misses 5366 5830 +464
- Partials 1219 1307 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WIP: refactor new methods to builder pattern! -> Done! |
79943ea
to
e8ab1c7
Compare
@Standing-Man You've modified the workflows. Please don't forget to update the .mergify.yml. |
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days |
Hi @bsbds, PTAL. |
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days |
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
e8ab1c7
to
37dfd77
Compare
fixed #604
Please briefly answer these questions: