Adding test coverage to EngineWrapper #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implemented yet; fixed bug where EngineWrapper was invoking JS methods with a Work.ArgType.Raw as a parameter instead of that Raw's Object field
oconnor0
reviewed
Jan 28, 2025
oconnor0
reviewed
Jan 28, 2025
oconnor0
approved these changes
Jan 28, 2025
…re out why cancellation isn't working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests that covered current working capabilities of EngineWrapper. Also fixed bug where the wrong object was being passed as a parameter when invoking JS methods