Dev/2decomp gitsub #4
Conversation
This tracks our (Xcompact3d) fork of the upstream (NAG) 2decomp&fft - however we have clearly diverged somewhat from 2decomp&fft so currently does not build
Add instructions to initialise and update the 2decomp&fft submodule.
|
HI guys I need to check how to do the CMake with submodules. As i can see in the Make you just update the path where the source is. In CMake I have files to add under decomp2d. I don’t know how practical this will be. |
|
@rfj82982 is it not possible to just call Make within cmake? In the new branch 2decomp is no longer built by x3div - it simply calls |
|
If you check the branch hack_doconcurrent in the CMakeLists line 192. I am downloading and building a library to find fftw. I think we can execure a make, but if we do the same I did with this there is no need for a submodule and we can download, build and link decomp2d only during build time. I have to test and see what is the best option. |
|
Right now, I suspect 2decomp in x3div/hack_doconcurrent differs from the 2decomp in xcompact3d, which probably also differs from nag/2decomp |
|
Whether it's a submodule or something else, we should move onto the "community" code - we get benefits from anyone else using it and vice-versa. Xcompact3d's 2decomp definitely diverges, we have an opportunity here to correct that I think. P.S. - what if I have a system FFTW (such as cray-fftw which should be optimised for the hardware) and don't want to download and build FFTW? |
|
For instance - one option would be to push cmake upstream into 2decomp&fft |
|
The package just look for the fft available in the system. If you have fftw from cray will just find it based on the module loaded and check all the bits of fftw available and five you the right bits that you can link to your build. |
Adds 2decomp as a submodule