Unify foreign key options in create_table, create_constraint and column level constraints
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
commented
Jan 28, 2025
| break | ||
| } | ||
| return true | ||
| return !constraint.SkipValidation |
There was a problem hiding this comment.
The constraint writer already supports skipping validation. But I am adding it to sql2pgroll later.
| }, | ||
| "on_update": { | ||
| "description": "On update behavior of the foreign key constraint", | ||
| "$ref": "#/$defs/ForeignKeyOnDelete", |
There was a problem hiding this comment.
Looks like the wrong $ref here.
There was a problem hiding this comment.
No, it is on purpose. ON UPDATE and ON DELETE have the same actions, so we can reuse it in both places. But I can rename it to make clearer that it is intentional.
|
Requires #639. |
kvch
added a commit
that referenced
this pull request
Jan 29, 2025
This PR renames `ForeignKeyReferenceOnDelete` to `ForeignKeyAction`. The name was too long. Also, `ON DELETE` and `ON UPDATE` referential actions are the same. This name makes it clearer that we are reusing this enum for both options. Extracted from #628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the beginning of unifying constraint options all over
pgroll. This addresses the missing options in column level foreign key constraints andcreate_constraintoperation.Now more foreign key options are supported:
match_typein column definitions and increate_constrainton_updatein column definitions and increate_constrainton_delete_set_columnsincreate_constraintIt also comes with several refactorings and simplifications:
ForeignKeyReferenceOnDeleteNOACTIONand others are renamed toForeignKeyOnDeleteNOACTION, because my eyes were bleeding from the long namesTableForeignKeyReferenceis used in bothconstraintsofcreate_tableandcreate_constraintoperationConstraintSQLWriteris used in adding new columns, creating constraints and creating tablesConstraintSQLWritercan produce not validated constraintsconvertFkConstraintinsql2pgrollis the unified way to process FK constraints of columns and tablesWhat comes next in future PRs?
ConstraintSQLWriterinto a separate file and adding unit tests, as it is used from several parts of the codebase nowConstraintSQLWriterto support other constraint types for columns and creating constraintsunique,primary_keyandcheckconstraints optionssql2pgroll