Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interacting with the window border (minimizing/resizing/moving window/etc) or sometimes switching to fullscreen, pauses playback #4

Open
xNul opened this issue Oct 6, 2017 · 3 comments
Labels

Comments

@xNul
Copy link
Owner

xNul commented Oct 6, 2017

Because of commit 93eec1a, there is now a bug where music temporarily stops due to the above reasons. In order to fix, audio would have to be moved to a separate thread, but even then it doesn't account for the visual stall.

@xNul xNul added the bug label Oct 6, 2017
@xNul
Copy link
Owner Author

xNul commented Apr 29, 2018

Identified issue and submitted a bug report to the official LOVE repo here

@zorggn
Copy link

zorggn commented Dec 28, 2018

Since the above linked issue was closed as "not viable to implement" basically, i could suggest that, at least for continuous sound playback, another löve thread could be used to do the QSource data queueing on, as you already mentioned; can't do too much about the visuals at this point sadly.

(As an aside, i did a test project myself sometime in the past with threading, and i managed to put everything on the lua side, except love.event.pump and graphics and window calls in love.run into a separate thread, but i must admit, i haven't experimented further with it; maybe it'd be possible to somehow transfer/access those from the separate thread as well...)

@xNul
Copy link
Owner Author

xNul commented Jan 3, 2019

I'm planning to put audio playback in a separate thread, but getting everything working from a separate thread (or only graphics + audio) would be a complete solution. I'll do some experimenting when I come back to this project and hopefully figure out a workaround, although, I doubt it :(

@xNul xNul changed the title Interacting with the window border (minimizing/resizing/moving window/etc) or sometimes switching to fullscreen, pauses the song Interacting with the window border (minimizing/resizing/moving window/etc) or sometimes switching to fullscreen, pauses playback Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants