Queue detailed statuses #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystian-panek-vmltech
requested review from
tomasz-sobczyk-wttech,
mariusz-pacyga-wttech and
dominik-przybyl-wttech
| @@ -8,14 +8,27 @@ | |||
| import org.apache.sling.event.jobs.Job; | |||
|
|
|||
| public enum ExecutionStatus { | |||
There was a problem hiding this comment.
I just expanded ACTIVE into PARSING,CHECKING,RUNNING;
ACTIVE remains because I need something for warmup/init time (opening resource resolver etc; and we don't know if when sling job says ACTIVE then our async groovy execution starts immediately)
| } | ||
|
|
||
| switch (job.getJobState()) { | ||
| case QUEUED: | ||
| return ExecutionStatus.QUEUED; | ||
| case ACTIVE: | ||
| return ExecutionStatus.ACTIVE; | ||
| return executor.checkStatus(job.getId()).orElse(ExecutionStatus.ACTIVE); |
There was a problem hiding this comment.
if executor has not yet registered ID in in-memory map we assume that it is an init phase (ACTIVE status)
| statuses.put(context.getId(), ExecutionStatus.PARSING); | ||
|
|
||
| if (context.getOutputStream() != null) { | ||
| context.setOutputStream(new TeeOutputStream(outputStream, context.getOutputStream())); |
There was a problem hiding this comment.
allows to write somewhere else optionally / future hook
mariusz-pacyga-wttech
approved these changes
Mar 21, 2025
| )} | ||
| </> | ||
| ); | ||
| return <Meter aria-label={label} variant={variant} showValueLabel={false} value={100} label={`${label} after ${formatter.durationShort(execution.duration)}`} />; |
There was a problem hiding this comment.
I don't think aria-label is necessary if label is defined
|
|
||
| const formatter = useFormatter(); | ||
| if (!execution) { | ||
| return <Meter aria-label={label} label={label} showValueLabel={false} value={0} />; |
There was a problem hiding this comment.
I don't think aria-label is necessary if label is defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.