From 30b10eca8cb716d4b9fb70705be825301dc1feb3 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Fri, 9 Sep 2022 03:02:27 +0000 Subject: [PATCH] vuln-fix: Partial Path Traversal Vulnerability This fixes a partial path traversal vulnerability. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`. To demonstrate this vulnerability, consider `"/usr/outnot".startsWith("/usr/out")`. The check is bypassed although `/outnot` is not under the `/out` directory. It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object. For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`; however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`. Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') Severity: Medium CVSSS: 6.1 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.PartialPathTraversalVulnerability) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/13 Co-authored-by: Moderne --- .../apache/axis2/classloader/DirectoryResourceLocation.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/kernel/src/org/apache/axis2/classloader/DirectoryResourceLocation.java b/modules/kernel/src/org/apache/axis2/classloader/DirectoryResourceLocation.java index ea71adc13..1e03ef84f 100644 --- a/modules/kernel/src/org/apache/axis2/classloader/DirectoryResourceLocation.java +++ b/modules/kernel/src/org/apache/axis2/classloader/DirectoryResourceLocation.java @@ -52,8 +52,7 @@ public ResourceHandle getResourceHandle(String resourceName) { private boolean isLocal(File file) { try { String base = baseDir.getCanonicalPath(); - String relative = file.getCanonicalPath(); - return (relative.startsWith(base)); + return (file.getCanonicalFile().toPath().startsWith(base)); } catch (IOException e) { return false; }