Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix org role update filter issue. #2710

Merged

Conversation

Malith-19
Copy link
Contributor

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.46%. Comparing base (fe8c68e) to head (975e867).
Report is 38 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2710      +/-   ##
============================================
- Coverage     56.65%   56.46%   -0.20%     
- Complexity     8542     8556      +14     
============================================
  Files           654      654              
  Lines         48355    48679     +324     
  Branches      10073    10156      +83     
============================================
+ Hits          27396    27487      +91     
- Misses        17063    17279     +216     
- Partials       3896     3913      +17     
Flag Coverage Δ
unit 39.90% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13358641552

@SujanSanjula96
Copy link
Contributor

Fix is correct. Shall we try to improve the variable names as well to convey the flow more accurately?

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13358641552
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13380628345

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13380628345
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13380628345

@SujanSanjula96 SujanSanjula96 merged commit 3e976fe into wso2-extensions:master Feb 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants