Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picking correct domain qualified name of shared user for user claim retrieval on organization switch #2708

Merged

Conversation

AnuradhaSK
Copy link
Contributor

Proposed changes in this pull request

Fix wso2/product-is#23031

Screen.Recording.2025-02-14.at.00.02.36.mov

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13314713839

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.61%. Comparing base (3d191a2) to head (501cde5).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...2/carbon/identity/openidconnect/OIDCClaimUtil.java 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2708      +/-   ##
============================================
+ Coverage     56.54%   56.61%   +0.07%     
+ Complexity     8543     8537       -6     
============================================
  Files           654      654              
  Lines         48522    48417     -105     
  Branches      10131    10111      -20     
============================================
- Hits          27436    27413      -23     
+ Misses        17172    17109      -63     
+ Partials       3914     3895      -19     
Flag Coverage Δ
unit 39.77% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13314713839
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13314713839

@AnuradhaSK AnuradhaSK merged commit 5d0dcbf into wso2-extensions:master Feb 13, 2025
3 of 4 checks passed
@AnuradhaSK AnuradhaSK deleted the secondary-userstore-issue branch February 13, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to obtain OIDC claims for a secondary userstore's user switching to sub org when there is a shared user
3 participants