Synchronize persisting token in RefreshGrantHandler #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoshani
force-pushed
the
improve-refresh-grant-handler
branch
2 times, most recently
from
7af05a7 to
122a6fd
Compare
Yoshani
force-pushed
the
improve-refresh-grant-handler
branch
from
122a6fd to
c0dfd94
Compare
kayathiri4
approved these changes
Dec 14, 2023
senthalan
reviewed
Dec 14, 2023
.../src/main/java/org/wso2/carbon/identity/oauth2/token/handlers/grant/RefreshGrantHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
The
RefreshGrantHandlerbypasses the synchronized token issuing behavior of the super classAbstractAuthorizationGrantHandlerby adopting an overiddenissuemethod. This can potentially be the reason for the related issue. Therefore this PR adopts the same synchronization method when persisting the token inRefreshGrantHandler.Related Issues