observation reports - allow only pdfs

wri · Feb 4, 2025 · 3fd61f9 · 3fd61f9
1 parent db3470d
commit 3fd61f9
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/app/admin/observation_report.rb b/app/admin/observation_report.rb
@@ -139,7 +139,7 @@ def apply_filtering(chain)
       f.input :user
       f.input :title
       f.input :publication_date, as: :date_time_picker, picker_options: {timepicker: false, format: "Y-m-d"}
-      f.input :attachment, as: :file, hint: f.object&.attachment&.file&.filename
+      f.input :attachment, as: :file, hint: f.object&.attachment&.file&.filename, input_html: {accept: "application/pdf"}
       f.input :observers
     end
 

diff --git a/app/uploaders/observation_report_uploader.rb b/app/uploaders/observation_report_uploader.rb
@@ -2,7 +2,7 @@
 
 class ObservationReportUploader < ApplicationUploader
   def extension_allowlist
-    %w[pdf doc docx txt csv xml jpg jpeg png exif tiff bmp]
+    %w[pdf]
   end
 
   def filename

diff --git a/spec/factories/observation_reports.rb b/spec/factories/observation_reports.rb
@@ -16,7 +16,7 @@
   factory :observation_report do
     sequence(:title) { |n| "ObservationReportTitle#{n}" }
     publication_date { DateTime.current }
-    attachment { Rack::Test::UploadedFile.new(File.join(Rails.root, "spec", "support", "files", "image.png")) }
+    attachment { Rack::Test::UploadedFile.new(File.join(Rails.root, "spec", "support", "files", "doc.pdf")) }
     observers { build_list(:observer, 1) }
 
     after(:build) do |random_observation_report|

diff --git a/spec/models/observation_report_spec.rb b/spec/models/observation_report_spec.rb
@@ -31,6 +31,15 @@
       expect(subject).not_to be_valid
       expect(subject.errors.messages[:attachment]).to include("can't be blank")
     end
+
+    it "accepts only pdf files" do
+      subject.attachment = Rack::Test::UploadedFile.new(File.join(Rails.root, "spec", "support", "files", "image.png"))
+      expect(subject).not_to be_valid
+      expect(subject.errors.messages[:attachment]).to include("You are not allowed to upload \"png\" files, allowed types: pdf")
+      subject = build(:observation_report) # somehow just changing the attachment do not reset that validation error, probably carrierwave bug
+      subject.attachment = Rack::Test::UploadedFile.new(File.join(Rails.root, "spec", "support", "files", "doc.pdf"))
+      expect(subject).to be_valid
+    end
   end
 
   describe "hooks" do