Jmdots/v0.2.1 #17
Open
Jmdots/v0.2.1 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The make server was experiencing unhandled TaskGroup errors when subprocess operations failed. This update improves error handling by: - Replace proc.communicate() with explicit TaskGroup-based stream reading - Add proper exception handling for TaskGroup errors including ExceptionGroup - Improve subprocess cleanup on errors and cancellation - Add explicit error logging to stderr for server process errors This change fixes the "unhandled errors in TaskGroup" issue that was causing Claude Desktop to hang when subprocess operations failed. Note: A follow-up PR should add more comprehensive tests for subprocess error scenarios and TaskGroup error handling.
The make server had issues with unhandled subprocess errors and type safety. This update improves error handling and type checking by: - Replace TaskGroup with explicit asyncio.gather() and task management - Add proper type hints and casting for StreamReader objects - Improve subprocess cleanup on errors and cancellation - Add better error context propagation - Fix mypy type checking issues The changes ensure proper handling of subprocess failures and maintain type safety throughout the codebase. All linting and type checks now pass. Note: Consider adding more test cases for subprocess error scenarios in a future update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.