Merge pull request #158 from wrabit/revert_isolated_context

reverted isolated context
wrabit · Sep 20, 2024 · a89ef66 · a89ef66
2 parents 5eed005 + 6a69813
commit a89ef66
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/django_cotton/templatetags/_component.py b/django_cotton/templatetags/_component.py
@@ -63,12 +63,14 @@ def render(self, context):
         }
 
         template = self._get_cached_template(context, component_data["attrs"])
-        output = template.render(context.new(component_state))
-        cotton_data["stack"].pop()
+        # excludes builtin + custom context processors
+        # output = template.render(context.new(component_state))
+
+        # provides global
+        with context.push(component_state):
+            output = template.render(context)
 
-        # if not isolated, future 'only' support?:
-        # with context.push(component_state):
-        #     output = template.render(context)
+        cotton_data["stack"].pop()
 
         return output
 

diff --git a/django_cotton/tests/test_basic.py b/django_cotton/tests/test_basic.py
@@ -1,3 +1,5 @@
+from unittest import skip
+
 from django_cotton.tests.utils import CottonTestCase
 
 
@@ -103,12 +105,12 @@ def test_loader_scans_all_app_directories(self):
                 """My template path was not specified in settings!""",
             )
 
+    @skip("Not implemented")
     def test_components_have_isolated_context(self):
         self.create_template(
             "cotton/isolated_context.html",
             """{{ outer }}""",
         )
-
         self.create_template(
             "isolated_context_view.html",
             """