Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7115 LazyLoad Background images inside <aside> tag #7228

Closed
wants to merge 2 commits into from

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Jan 14, 2025

Description

Fixes #7115

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Check #7115

Technical description

Documentation

Add aside tag to the lazyload background images.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Copy link

codacy-production bot commented Jan 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e726c3d1 50.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e726c3d) Report Missing Report Missing Report Missing
Head commit (9cc9140) 38760 17142 44.23%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7228) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal marked this pull request as ready for review January 14, 2025 17:21
@Khadreal Khadreal requested a review from a team January 14, 2025 23:04
@jeawhanlee
Copy link
Contributor

There's tests failing in CI here Other than that, looks good to me.

@wordpressfan
Copy link
Contributor

This is not the correct way to include the library inside the core code, we released v3.0.17 Here: https://github.com/wp-media/rocket-lazyload-common/releases/tag/v3.0.17

and opened a new PR to have all the changes: #7235

@Khadreal
Copy link
Contributor Author

Closing this, the PR is already covered here

@Khadreal Khadreal closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyLoad - LazyLoad Background images inside <aside> tag
3 participants