-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Multisite Cache Deletion Issue with lazyload background images feature #7226
Fix Multisite Cache Deletion Issue with lazyload background images feature #7226
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
For test:
|
Working fine (failed tests are already failing on 3.18)
|
Description
Fixes #6340
Here we unify the caching directory path for lazyload background images feature.
Type of change
Detailed scenario
Everything is mentioned in the issue itself, u can install multisite and add some background images in some pages (different sub-sites) then in one site try clearing the cache, this will remove the background images for all sub-sites.
Technical description
Here we unify the way that we instantiate "lazyload_css_cache" in the container service provider.
Documentation
N/A
New dependencies
N/A
Risks
I think we will need to clear cache with update to that version because the files urls are changed, but need to confirm that with QA and product.
Mandatory Checklist
Code validation
Code style
Unticked items justification
N/A
Additional Checks